Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] New Trial template design #1341

Closed
andreyvelich opened this issue Sep 16, 2020 · 5 comments · Fixed by kubeflow/website#2332
Closed

[Documentation] New Trial template design #1341

andreyvelich opened this issue Sep 16, 2020 · 5 comments · Fixed by kubeflow/website#2332

Comments

@andreyvelich
Copy link
Member

andreyvelich commented Sep 16, 2020

/area docs

We should document our new trial template design and how to use new CRD in the Trial template.

Since user doesn't need to manually modify controller source code to support new CRD, do we need new-trial-kind in our Katib repository ?
Or it is better to add this information under https://www.kubeflow.org/ website ?

@gaocegege @johnugeorge What do you think ?

@k8s-ci-robot
Copy link

@andreyvelich: The label(s) kind/docs cannot be applied, because the repository doesn't have them

In response to this:

/kind docs

We should document our new trial template design and how to use new CRD in the Trial template.

Since user doesn't need to manually modify controller source code to support new CRD, do we need new-trial-kind in our Katib repository ?
Or it is better to add this information under https://www.kubeflow.org/ website ?

@gaocegege @johnugeorge What do you think ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/docs 0.58
area/katib 0.94

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.61

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@andreyvelich
Copy link
Member Author

/area release
/priority p1

@gaocegege
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants