Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] The future of Trial metadata parameters. #2390

Open
Electronic-Waste opened this issue Jul 17, 2024 · 3 comments
Open

[Discussion] The future of Trial metadata parameters. #2390

Electronic-Waste opened this issue Jul 17, 2024 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Electronic-Waste
Copy link
Member

Electronic-Waste commented Jul 17, 2024

As we discuss in issue #2369 , we choose to always pass the Trial name as env variable KATIB_TRIAL_NAME to the training container. And we implemented this feature as function mutatePodEnv and used it here:

// Add Katib Trial labels to the Pod metadata.
mutatePodMetadata(mutatedPod, trial)

Here are some discussions about it: #2369 (comment) #2369 (comment) #2369 (comment)

We use this issue to track the discussion. Any suggestions are welcome!

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member

/remove-lifecycle stale
/good-first-issue

Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/remove-lifecycle stale
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot added good first issue Good for newcomers help wanted Extra attention is needed and removed lifecycle/stale labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants