Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go] Establish vendor dependencies for go #5

Closed
gaocegege opened this issue Apr 4, 2018 · 4 comments
Closed

[go] Establish vendor dependencies for go #5

gaocegege opened this issue Apr 4, 2018 · 4 comments
Labels
priority/p2

Comments

@gaocegege
Copy link
Member

I am trying to build manager and other binaries from source code but it seems that we do not import all vendors. I think we should use dep or glide to establish vendor dependencies.
@gaocegege
Copy link
Member Author

Hi @YujiOshima

Could you please where the dep vendor/github.com/osrg/dlk is, I can not find it in GitHub.

@YujiOshima
Copy link
Contributor

I'm sorry, dlk is not in public Github repo.
It is the only wrapper for k8s API. dlk/LearningTask is similar to TFJob.
I want to replace it with TFJob.
So how about we move it from vendor directory and introduce vendoring tool.
Then we try to replace.

@gaocegege
Copy link
Member Author

@YujiOshima SGTM 🎉

@YujiOshima YujiOshima mentioned this issue Apr 4, 2018
Merged
@gaocegege
Copy link
Member Author

I reopened the issue since we have no vendor now.

@gaocegege gaocegege reopened this Apr 5, 2018
@gaocegege gaocegege mentioned this issue Apr 6, 2018
Merged
gaocegege added a commit to gaocegege/katib that referenced this issue May 23, 2019
@gaocegege @caicloud-bot
feat(experiment): Communicate with suggestion services to get suggest…
faada3d 
…ions (kubeflow#5)

* feat(experiment): support suggestion

Signed-off-by: Ce Gao <[email protected]>

* fix: Add a TODO

Signed-off-by: Ce Gao <[email protected]>

* fix: Fix bug about loop

Signed-off-by: Ce Gao <[email protected]>

* fix: Fix test cases

Signed-off-by: Ce Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaocegege @YujiOshima