Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Sorting for Trials information table #1251

Merged
merged 3 commits into from
Jul 3, 2020
Merged

UI: Sorting for Trials information table #1251

merged 3 commits into from
Jul 3, 2020

Conversation

andreyvelich
Copy link
Member

Fixes: #1095.
I added sorting by each Trial table column in Experiment monitor.
Sort Trial

/assign @johnugeorge @gaocegege

/cc @terrykong

@k8s-ci-robot
Copy link

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: terrykong.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Fixes: #1095.
I added sorting by each Trial table column in Experiment monitor.
Sort Trial

/assign @johnugeorge @gaocegege

/cc @terrykong

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubeflow-bot
Copy link

This change is Reviewable

gaocegege
gaocegege reviewed Jul 3, 2020
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ea1bb06 into kubeflow:master Jul 3, 2020
sperlingxx pushed a commit to sperlingxx/katib that referenced this pull request Jul 9, 2020
@andreyvelich @sperlingxx
UI: Sorting for Trials information table (kubeflow#1251)
45b597e 
* Enable sort in Trials table

* Remove console log

* Modify cell width
@andreyvelich andreyvelich mentioned this pull request Feb 18, 2021
Closed
@andreyvelich andreyvelich deleted the issue-1095-ui-sort-trial-table branch October 6, 2021 00:27
@ryan-ally ryan-ally mentioned this pull request Nov 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

Assignees

@johnugeorge johnugeorge

@gaocegege gaocegege

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sorting trials by columns in UI
5 participants
@andreyvelich @k8s-ci-robot @kubeflow-bot @gaocegege @johnugeorge