-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metrics-collector): allow user to nuke ephemeral-storage requests #1312
fix(metrics-collector): allow user to nuke ephemeral-storage requests #1312
Conversation
Hi @khersey. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8ba028e
to
7061e43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @khersey!
/ok-to-test
7061e43
to
173719e
Compare
/retest |
@gaocegege Test will not work until we fix this problem: kubeflow/testing#749 (comment). |
/retest |
I believe you also need to rebase to fix e2e tests. |
173719e
to
61095c4
Compare
@khersey Thanks for the rebase. Can you revert gofmt changes from I will update |
@andreyvelich yeah sorry for the delay, will do. Looks like the frontend tests are failing, not sure that's related to my changes |
I believe we need to modify nvm version in Travis for frontend tests. |
@andreyvelich ok api.pb formatting changes have been nuked 💣 |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @khersey!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1289
Special notes for your reviewer: