Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gRPC manager build script #1492

Merged

Conversation

andreyvelich
Copy link
Member

We are currently unable to re-run build.sh script to generate gRPC manager APIs.
I am getting this error:

:/apiprotos protoc-gen-doc --doc_opt=markdown,api.md -I /protobuf -I /apiprotos api.proto
[libprotobuf WARNING ../../../../../src/google/protobuf/compiler/parser.cc:562] No syntax specified for the proto file: google/api/annotations.proto. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)
google/api/annotations.proto:1:1: Expected top-level statement (e.g. "message").
api.proto: Import "google/api/annotations.proto" was not found or had errors.

As I can see, the annotations and grpc-gateway_out scripts were added as part of this PR: #142.
We are not using REST manager more and that should be removed.
As well, I removed legacy Manager Swagger and Makefile.

/assign @gaocegege @johnugeorge

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
/lgtm

@google-oss-robot google-oss-robot merged commit b65e4c3 into kubeflow:master Mar 20, 2021
@andreyvelich andreyvelich deleted the fix-grpc-annotation-error branch October 6, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants