Add Support for Argo Workflows #1605
Conversation
|
/hold for the review |
|
/cc @terrytangyuan |
examples/v1beta1/argo/README.md
Outdated
|
|
||
| Here you can find examples of using Katib with [Argo Workflows](https://github.com/argoproj/argo-workflows). | ||
|
|
||
| **Note:** You have to install `Argo >= v3.1` to use it in Katib Experiments. |
There was a problem hiding this comment.
v3.1.3 to be consistent with below? Otherwise need to verify v3.1 works in general
There was a problem hiding this comment.
Sure, thank you for pointing this.
| @@ -62,6 +62,12 @@ rules: | |||
| - taskruns | |||
| verbs: | |||
| - "*" | |||
| - apiGroups: | |||
There was a problem hiding this comment.
If users are not using Argo, they’ll have to add these permissions? I’d recommend adding these to a separate file to help users who would like to use Argo
There was a problem hiding this comment.
+1 But,we didn't do this for other operators as well
There was a problem hiding this comment.
@terrytangyuan @johnugeorge Do you think it's better to add steps for updating Katib controller and RBAC to appropriate README. For example, for Argo: https://github.com/kubeflow/katib/blob/8acbffcab5ce8d74742967a8d3665ab72faf351c/examples/v1beta1/argo/README.md and for Tekton: https://github.com/kubeflow/katib/tree/master/examples/v1beta1/tekton
There was a problem hiding this comment.
Yes I think that should be fine.
andreyvelich
force-pushed
the
issue-1081-support-argo-workflow
branch
from
d206da5
to
17455d7
Compare
|
I've made changes for Tekton and Argo docs. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, gaocegege, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
Fixes: #1081.
I was able to integrate Argo Workflows in Katib's Experiment.
Thanks to @alexec and @terrytangyuan for helping with this issue: argoproj/argo-workflows#4545.
Please take a look.
/assign @gaocegege @johnugeorge
cc @jbottum @terrykong @nielsmeima