Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default image for the new Katib UI #1608

Merged
merged 9 commits into from
Aug 11, 2021

Conversation

andreyvelich
Copy link
Member

Related: #1597.

As we discussed, for Kubeflow 1.4 in the default Katib manifests we will use the new Katib UI image.
We still need to make some changes in the website docs: #1595 before the release.

I modified Katib README, please take a look.

/assign @kimwnasptd @gaocegege @johnugeorge

/hold for the review.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member Author

We should decide which image we are going to use for the new Katib UI.
Maybe we can re-use docker.io/kubeflowkatib/katib-ui and users can deploy docker.io/kubeflowkatib/katib-ui:v0.11.1 for the previous UI.
Currently, AWS Test infra has only docker.io/kubeflowkatib/katib-ui image: https://github.com/kubeflow/testing/blob/master/aws/IaC/CDK/test-infra/config/static_config/ECR_Resources.py#L13.

/hold

@gaocegege
Copy link
Member

docker.io/kubeflowkatib/katib-ui SGTM

@johnugeorge
Copy link
Member

SGTM

@andreyvelich
Copy link
Member Author

I am using docker.io/kubeflowkatib/katib-ui for the new UI.
@gaocegege @kimwnasptd @johnugeorge Please take a look.

/hold cancel

@andreyvelich
Copy link
Member Author

/retest

@andreyvelich
Copy link
Member Author

Tests are passed, @kimwnasptd @gaocegege @johnugeorge if you are fine with the changes let's merge it.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot google-oss-robot merged commit c24d303 into kubeflow:master Aug 11, 2021
@andreyvelich andreyvelich deleted the default-new-ui-image branch October 12, 2021 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants