Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry-pick: UI fix for handling missing params #1657

Merged
merged 1 commit into from
Sep 7, 2021
Merged

cherry-pick: UI fix for handling missing params #1657

merged 1 commit into from
Sep 7, 2021

Conversation

kimwnasptd
Copy link
Member

Cherry-pick changes from #1652

/cc @andreyvelich

@kimwnasptd @andreyvelich
UI: Handle missing TrialTemplates (kubeflow#1652)
6eb107b 
* Use YAML input if TrialParams are missing

Signed-off-by: Kimonas Sotirchos <[email protected]>

* review: Separate TrialTemplates in two words

Co-authored-by: Andrey Velichkevich <[email protected]>

Co-authored-by: Andrey Velichkevich <[email protected]>
@google-cla
Copy link

google-cla bot commented Sep 6, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@andreyvelich
Copy link
Member

@googlebot I consent.

andreyvelich
andreyvelich approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member

/retest

6 similar comments
@andreyvelich
Copy link
Member

/retest

@andreyvelich
Copy link
Member

/retest

@andreyvelich
Copy link
Member

/retest

@andreyvelich
Copy link
Member

/retest

@andreyvelich
Copy link
Member

/retest

@andreyvelich
Copy link
Member

/retest

@google-oss-robot google-oss-robot merged commit 9316862 into kubeflow:release-0.12 Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich andreyvelich approved these changes

Assignees

@andreyvelich andreyvelich

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimwnasptd @andreyvelich @google-oss-robot