-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Support log-uniform scale in search space definition #1708
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fabianvdW The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @fabianvdW. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @fabianvdW, Are you still working on this PR ? If you don't mind I'd like to add some more features based on this PR. |
Not currently working on this. I don't have enough insight to finish this on my own. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/ok-to-test |
@fabianvdW: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hello everyone,
I would like to see some movement in #1207. I started by adding the distribution field everywhere I could find and already modifying the behaviour in the suggestion package at relevant places.
I am guessing this PR is not even close to finished. Maybe someone can point out to me which parts are still missing(and or have to be adapated), or discuss if my approach to fixing #1207 is good. Perhaps one of the main contributors can also take over from here.
What this PR does / why we need it:
This adds a field distribution to SearchSpace which allows for the "log-uniform" scale (and possibly other scales) to be supported for sampling from parameter search spaces.
Fixes #1207
Checklist: