Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Support log-uniform scale in search space definition #1708

Closed
wants to merge 1 commit into from

Conversation

fabianvdW
Copy link
Contributor

Hello everyone,

I would like to see some movement in #1207. I started by adding the distribution field everywhere I could find and already modifying the behaviour in the suggestion package at relevant places.

I am guessing this PR is not even close to finished. Maybe someone can point out to me which parts are still missing(and or have to be adapated), or discuss if my approach to fixing #1207 is good. Perhaps one of the main contributors can also take over from here.
What this PR does / why we need it:
This adds a field distribution to SearchSpace which allows for the "log-uniform" scale (and possibly other scales) to be supported for sampling from parameter search spaces.

Fixes #1207

Checklist:

  • Docs included if any changes are user facing

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fabianvdW
To complete the pull request process, please assign andreyvelich after the PR has been reviewed.
You can assign the PR to them by writing /assign @andreyvelich in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aws-kf-ci-bot
Copy link
Contributor

Hi @fabianvdW. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anencore94
Copy link
Member

Hi @fabianvdW, Are you still working on this PR ? If you don't mind I'd like to add some more features based on this PR.

@fabianvdW
Copy link
Contributor Author

Hi @fabianvdW, Are you still working on this PR ? If you don't mind I'd like to add some more features based on this PR.

Not currently working on this. I don't have enough insight to finish this on my own.

@stale
Copy link

stale bot commented Apr 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@johnugeorge
Copy link
Member

/ok-to-test

@aws-kf-ci-bot
Copy link
Contributor

@fabianvdW: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-katib-presubmit 3f500a2 link /test kubeflow-katib-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Support log-uniform scale in search space definition
5 participants