[new-ui] Bump angular version to 12 #1712

seong7 · 2021-10-13T01:46:39Z

What this PR does / why we need it:
Updates Angular version from 8 to 12 (latest).
Details are described in the issue #1590

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1590

Checklist:

Docs included if any changes are user facing

…7.0)

aws-kf-ci-bot · 2021-10-13T01:46:52Z

Hi @seong7. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-robot · 2021-10-13T01:46:53Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: seong7
To complete the pull request process, please assign kimwnasptd after the PR has been reviewed.
You can assign the PR to them by writing /assign @kimwnasptd in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

pkg/new-ui/v1beta1/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kimwnasptd · 2021-11-26T11:38:57Z

@seong7 could you instead use either node v12 or node v14 and update the package-lock.json? Doing an npm i should do the trick, after you used on of the above versions.

I'm OK with going with node v14 as well, but in that case please add a commit to:

Update the README of the frontend to mention the new version of Node, and lets also mention the npm version https://github.com/kubeflow/katib/blob/master/pkg/new-ui/v1beta1/README.md#requirements
Update the dockerfile of the web app to use that version of node in https://github.com/kubeflow/katib/blob/master/cmd/new-ui/v1beta1/Dockerfile#L12 and in https://github.com/kubeflow/katib/blob/master/cmd/new-ui/v1beta1/Dockerfile#L24

andreyvelich · 2021-11-30T22:02:39Z

Thank you for the review @kimwnasptd.
@seong7 What do you think about this PR ? Are we going to finish it before Kubeflow 1.5 release ?

seong7 · 2021-12-01T03:34:32Z

@kimwnasptd
Since this PR is entitled to bump Angular version not Node and npm, I think we better stick with node v12 and npm 6.
For Node and npm, we will need separated issue to work only if we need.
Thank you so much for dive deep deep down on this issue.

I will push a commit that rollbacks the version of lock file to v1.
Is there anything else I should do for it?

Probably we should update the README as below to specify the versions? WTYT?
https://github.com/kubeflow/katib/tree/master/pkg/new-ui/v1beta1#requirements

=> node (v12.18.1) and npm (v6.13)

@andreyvelich
When is the due date to finish the PR to get it included in Kubeflow 1.5?

kimwnasptd · 2021-12-01T10:29:08Z

Since this PR is entitled to bump Angular version not Node and npm, I think we better stick with node v12 and npm 6.
For Node and npm, we will need separated issue to work only if we need.

I completely agree!

I will push a commit that rollbacks the version of lock file to v1.
Probably we should update the README as below to specify the versions? WTYT?
https://github.com/kubeflow/katib/tree/master/pkg/new-ui/v1beta1#requirements

Perfect, these two would be awesome! We should be good to merge afterwards.

@andreyvelich
When is the due date to finish the PR to get it included in Kubeflow 1.5?

The currently proposed date is Jan 13 kubeflow/community#538 for the beginning of Feature Freeze. At that date the WGs should have a pass and pick which PRs, under review, should be merged for the next two weeks and also be very very conservative with adding new features.

But we are almost ready for merging this, so I don't think we'll have an issue with this PR

andreyvelich · 2021-12-01T15:16:38Z

Thanks for this information!
if we want to include this change to KF 1.5, we should merge it before January 15th.

seong7 · 2021-12-14T09:40:03Z

@kimwnasptd
Sorry for the delay.
I think this PR is ready to be merged now.
Please take a look into the 2 commits.

Thank you !

kimwnasptd · 2021-12-14T10:02:19Z

All tests have passed, so we should be good to go. Thank you so much for your effort @seong7, this was great work!

/lgtm
/approve

kimwnasptd · 2021-12-14T10:10:26Z

@andreyvelich this will also need an /approve from you as well, since it touches the README of the app

seong7 · 2022-01-02T23:48:35Z

@andreyvelich Can we proceed this PR before January 15th?

andreyvelich · 2022-01-06T03:40:57Z

@andreyvelich Can we proceed this PR before January 15th?

Sorry for the long reply @seong7.
I need some time to review the new changes.

I am on holidays until end of this week, and I will take a look at this PR on the next week.

seong7 · 2022-01-06T03:42:55Z

Thank you for replying @andreyvelich .
No problem.

andreyvelich · 2022-01-11T21:43:49Z

Overall, this PR looks good.
@seong7 Do we need to keep all these fonts under /assets/fonts ?

seong7 · 2022-01-12T02:29:11Z

Overall, this PR looks good. @seong7 Do we need to keep all these fonts under /assets/fonts ?

I don't think we need those font files, but it keeps being generated automatically on npm i.
I've done some research, but I can't figure out what makes these font files being generated.

andreyvelich · 2022-01-12T13:58:12Z

@seong7 As we discussed on the community meeting with @kimwnasptd we can add the font folder under .gitignone.
It is not necessary to have these files under Katib repository.

seong7 · 2022-01-13T00:19:46Z

@seong7 As we discussed on the community meeting with @kimwnasptd we can add the font folder under .gitignone.
It is not necessary to have these files under Katib repository.

@andreyvelich Thank you for the quick decision making. Please have look into the new commit.

andreyvelich · 2022-01-13T12:15:22Z

Thank you for the update @seong7!
Feel free to unhold this PR.
/lgtm
/approve
/cc @kimwnasptd

google-oss-prow · 2022-01-13T12:15:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, kimwnasptd, seong7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [andreyvelich]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

seong7 · 2022-01-13T13:56:07Z

Thank you @andreyvelich and @kimwnasptd for guiding me through this long process.
Couldn't have made it without your help!

/unhold

seong7 added 23 commits September 3, 2021 17:36

update README.md

f60a10b

npm install

a6d6778

version up : Angular 8 -> 9 / TS 3.5 -> 3.8

c2b51a2

version up: angular material 9

02a5724

remove deprecated entryComponents

6abc58d

edit depricated testBed.get -> testBed.inject

ded5d7a

Version up : @angular/core@10 /cli@10

a48d431

Version up : @angular/cdk, @angular/material 9 -> 10

f64744c

Version up : @angular/cdk-experimental 8 -> 10

f749888

dependency version up : @fortawesome/angular-fontawesome (0.5.0 -> 0.…

b8b1ca5

…7.0)

dependency version up : @swimlane/ngx-charts (13.0.4 -> 16.0.0)

aec6a14

ng update @angular/core@11 @angular/cli@11

18ed399

ng update @angular/material@11

884da97

npm install @angular/[email protected]

b4b478f

ng update @angular/core@12 @angular/cli@12

d1ff6c5

npm install @fortawesome/[email protected]

498ac5e

ng update @angular/material

263cc99

npm install @angular/[email protected]

216d1b0

npm install @swimlane/[email protected]

2afeae3

remvoe error line from @angular/compiler

91dd0e4

npm install @angular/[email protected]

9b85e8b

pull master

45e78f8

run format:write

82b1f2e

aws-kf-ci-bot added the needs-ok-to-test label Oct 13, 2021

google-oss-robot added the size/XXL label Oct 13, 2021

google-oss-robot requested review from andreyvelich, kimwnasptd and sperlingxx October 13, 2021 01:47

seong7 added 2 commits December 14, 2021 18:02

Rollback package-lock.json version to 1

b231bab

Update README.md

66e4fce

google-oss-prow bot removed the lgtm label Dec 14, 2021

google-oss-prow bot added the lgtm label Dec 14, 2021

remove assets/fonts by gitignore

e8983ed

google-oss-prow bot removed the lgtm label Jan 13, 2022

google-oss-prow bot assigned andreyvelich Jan 13, 2022

google-oss-prow bot added the lgtm label Jan 13, 2022

google-oss-prow bot added the approved label Jan 13, 2022

google-oss-prow bot removed the do-not-merge/hold label Jan 13, 2022

google-oss-prow bot merged commit ce5421e into kubeflow:master Jan 13, 2022

seong7 deleted the bump-angular-version-to12 branch January 13, 2022 14:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[new-ui] Bump angular version to 12 #1712

[new-ui] Bump angular version to 12 #1712

seong7 commented Oct 13, 2021 •

edited

Loading

aws-kf-ci-bot commented Oct 13, 2021

google-oss-robot commented Oct 13, 2021

kimwnasptd commented Nov 26, 2021

andreyvelich commented Nov 30, 2021

seong7 commented Dec 1, 2021 •

edited

Loading

kimwnasptd commented Dec 1, 2021

andreyvelich commented Dec 1, 2021

seong7 commented Dec 14, 2021

kimwnasptd commented Dec 14, 2021

kimwnasptd commented Dec 14, 2021

seong7 commented Jan 2, 2022

andreyvelich commented Jan 6, 2022

seong7 commented Jan 6, 2022

andreyvelich commented Jan 11, 2022

seong7 commented Jan 12, 2022

andreyvelich commented Jan 12, 2022

seong7 commented Jan 13, 2022 •

edited

Loading

andreyvelich commented Jan 13, 2022

google-oss-prow bot commented Jan 13, 2022

seong7 commented Jan 13, 2022 •

edited

Loading

[new-ui] Bump angular version to 12 #1712

[new-ui] Bump angular version to 12 #1712

Conversation

seong7 commented Oct 13, 2021 • edited Loading

aws-kf-ci-bot commented Oct 13, 2021

google-oss-robot commented Oct 13, 2021

kimwnasptd commented Nov 26, 2021

andreyvelich commented Nov 30, 2021

seong7 commented Dec 1, 2021 • edited Loading

kimwnasptd commented Dec 1, 2021

andreyvelich commented Dec 1, 2021

seong7 commented Dec 14, 2021

kimwnasptd commented Dec 14, 2021

kimwnasptd commented Dec 14, 2021

seong7 commented Jan 2, 2022

andreyvelich commented Jan 6, 2022

seong7 commented Jan 6, 2022

andreyvelich commented Jan 11, 2022

seong7 commented Jan 12, 2022

andreyvelich commented Jan 12, 2022

seong7 commented Jan 13, 2022 • edited Loading

andreyvelich commented Jan 13, 2022

google-oss-prow bot commented Jan 13, 2022

seong7 commented Jan 13, 2022 • edited Loading

seong7 commented Oct 13, 2021 •

edited

Loading

seong7 commented Dec 1, 2021 •

edited

Loading

seong7 commented Jan 13, 2022 •

edited

Loading

seong7 commented Jan 13, 2022 •

edited

Loading