Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Range for Int and Double values in Grid #1732

Merged

Conversation

andreyvelich
Copy link
Member

Fixes: #1636.

In Chocolate Suggestion quantized_uniform distribution uses half-open interval.

/assign @tenzen-y @gaocegege @johnugeorge

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for the fix.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 12, 2021
@google-oss-prow google-oss-prow bot merged commit 0e17302 into kubeflow:master Nov 12, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 73.786% when pulling 6fd42f6 on andreyvelich:issue-1636-fix-grid-int-range into cffab07 on kubeflow:master.

@andreyvelich andreyvelich deleted the issue-1636-fix-grid-int-range branch November 12, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid Algorithm fails for int parameters
5 participants