Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifests: Upgrade cert-manager API from v1alpha2 to v1 #1752

Merged
merged 1 commit into from
Jan 11, 2022
Merged

manifests: Upgrade cert-manager API from v1alpha2 to v1 #1752

merged 1 commit into from
Jan 11, 2022

Conversation

haoxins
Copy link
Contributor

@haoxins haoxins commented Nov 30, 2021

No description provided.

@aws-kf-ci-bot
Copy link
Contributor

Hi @haoxins. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update!
I left comment.

@@ -1,4 +1,4 @@
apiVersion: cert-manager.io/v1alpha2
apiVersion: cert-manager.io/v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it require any additional API changes after switching from v1alpha2 to v1 ?

cc @yanniszark @kimwnasptd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using cert-manager v1.3 in the manifests repo.

The cert-manager deprecated the following cert-manager APIs from v1.4

cert-manager.io/v1alpha2
cert-manager.io/v1alpha3
cert-manager.io/v1beta1
acme.cert-manager.io/v1alpha2
acme.cert-manager.io/v1alpha3
acme.cert-manager.io/v1beta1

https://cert-manager.io/docs/release-notes/release-notes-1.4/

And the latest cert-manager only supports v1 now.

@andreyvelich
Copy link
Member

/ok-to-test

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 74.264% when pulling 8aa2dba on haoxins:manifests-upgrade-cert-manager-from-v1alpha2-to-v1 into 1c7617c on kubeflow:master.

@haoxins
Copy link
Contributor Author

haoxins commented Dec 2, 2021

I also updated the kserve manifests kserve/kserve#1929

@haoxins
Copy link
Contributor Author

haoxins commented Dec 21, 2021

is this ready to merge?

@andreyvelich
Copy link
Member

Sorry for the late review @haoxins.
/lgtm
/approve
/cc @kimwnasptd

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, haoxins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ca79be1 into kubeflow:master Jan 11, 2022
@haoxins haoxins deleted the manifests-upgrade-cert-manager-from-v1alpha2-to-v1 branch January 12, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants