-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Uses Istio v1beta1 api #1828
Conversation
Hi @haoxins. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: haoxins The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for upgrading this @haoxins!
/ok-to-test
/lgtm |
we should hold this PR for a while. https://github.com/kubeflow/manifests/tree/master/apps/katib/upstream /hold |
Agreed, I will work on upgrade the Istio manifests into |
@kubeflow/wg-automl-leads If we use networking.istio.io/v1beta1, we need to merge this PR. |
There is nothing different between
v1alpha3
andv1beta1
currently IMO.But it's better to use
v1beta1
for the Istio upgrade in the future.