Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Uses Istio v1beta1 api #1828

Closed
wants to merge 1 commit into from
Closed

Chore: Uses Istio v1beta1 api #1828

wants to merge 1 commit into from

Conversation

haoxins
Copy link
Contributor

@haoxins haoxins commented Mar 3, 2022

There is nothing different between v1alpha3 and v1beta1 currently IMO.
But it's better to use v1beta1 for the Istio upgrade in the future.

@aws-kf-ci-bot
Copy link
Contributor

Hi @haoxins. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haoxins
To complete the pull request process, please assign andreyvelich after the PR has been reviewed.
You can assign the PR to them by writing /assign @andreyvelich in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 74.138% when pulling 64e5841 on haoxins:chore-istio-v1beta1 into 0515c1e on kubeflow:master.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for upgrading this @haoxins!

/ok-to-test

@tenzen-y
Copy link
Member

tenzen-y commented Mar 7, 2022

/lgtm

@johnugeorge
Copy link
Member

we should hold this PR for a while.
The manifests folder is synced to upstream Kubeflow/manifests for every release. Hence, it is better to match Istio version for other components as well.

https://github.com/kubeflow/manifests/tree/master/apps/katib/upstream

/hold

@haoxins
Copy link
Contributor Author

haoxins commented Mar 9, 2022

we should hold this PR for a while. The manifests folder is synced to upstream Kubeflow/manifests for every release. Hence, it is better to match Istio version for other components as well.

https://github.com/kubeflow/manifests/tree/master/apps/katib/upstream

/hold

Agreed, I will work on upgrade the Istio manifests into 1.13+ at first.

@tenzen-y
Copy link
Member

tenzen-y commented Jun 7, 2022

@kubeflow/wg-automl-leads
Which will be used, networking.istio.io/v1alpha3 or networking.istio.io/v1beta1 for VirtualService in the next major release of kubeflow?

If we use networking.istio.io/v1beta1, we need to merge this PR.

@haoxins haoxins closed this by deleting the head repository Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants