Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PBT to experiment creation form #1909

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

a9p
Copy link
Contributor

@a9p a9p commented Jun 29, 2022

What this PR does / why we need it:

This PR adds PBT as an option to the search algorithms drop-down for creating a new experiment from the Katib UI.

Related to: #1382, #1862

Checklist:

  • [-] Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Jun 29, 2022

Coverage Status

Coverage increased (+0.1%) to 72.974% when pulling d83cf22 on a9p:pbt-ui-newexp-only into cfa2d84 on kubeflow:master.

@a9p
Copy link
Contributor Author

a9p commented Jun 29, 2022

cc/ @johnugeorge - this adds minimal functionality to at least expose PBT options through the UI

@kimwnasptd
Copy link
Member

@johnugeorge the changes LGTM for the frontend. If you are also OK with the underlying logic and params exposed we should be good with merging this.

Although I'd suggest to first merge #1783, since it's easier to rebase this one later one if we have small conflicts. I'll give a heads up once I wrap the review of #1783.

/lgtm

@johnugeorge
Copy link
Member

Sure. We will wait for #1783 to get merged first
/hold

@johnugeorge
Copy link
Member

/hold cancel

@johnugeorge
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a9p, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3f2804b into kubeflow:master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants