Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] health check for katib-controller #1934

Merged

Conversation

anencore94
Copy link
Member

@anencore94 anencore94 commented Aug 20, 2022

What this PR does / why we need it:

  • Need to check readiness/liveness when deploying katib-controller
    • The main things that we need to check is whether the webhook server is started well.

I've referenced the health check way from other components:

So in my opinion, the liveness check with just ping is ok, but for readiness check, I'm not sure do we need more detailed way to check it or not.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1930

Checklist:

  • Docs included if any changes are user facing

@anencore94 anencore94 changed the title Feature/controller healthz [feat] health check for katib-controller Aug 20, 2022
@coveralls
Copy link

coveralls commented Aug 20, 2022

Coverage Status

Coverage decreased (-0.1%) to 73.431% when pulling e7b328f on anencore94:feature/controller-healthz into 96ab64b on kubeflow:master.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! @anencore94
I left a few comments.

cmd/katib-controller/v1beta1/main.go Show resolved Hide resolved
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you update this doc?

@anencore94
Copy link
Member Author

anencore94 commented Oct 6, 2022

Also, can you update this doc?

Thanks for checking carefully and sorry for the late reponse @tenzen-y :) I've updated it!

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anencore94 Thanks for the updates!
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Oct 6, 2022
@anencore94 anencore94 requested review from johnugeorge and removed request for sperlingxx October 11, 2022 10:43
@anencore94
Copy link
Member Author

Could you re-run the failed action and re-review if you don't mind? @johnugeorge

@johnugeorge
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anencore94, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit aaa42c1 into kubeflow:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Readiness/LivenessProbe endpoint for katib-controller
4 participants