Add --connect-timeout flag to katib-db-manager #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenzen-y
force-pushed
the
make-connectTimeout-confugurable
branch
from
702aa4c
to
998d011
Compare
|
I have force-pushed to restart actions. |
johnugeorge
reviewed
Aug 22, 2022
| @@ -28,4 +28,3 @@ WORKDIR /app | |||
| COPY --from=build-env /bin/grpc_health_probe /bin/ | |||
| COPY --from=build-env /go/src/github.com/kubeflow/katib/katib-db-manager /app/ | |||
| ENTRYPOINT ["./katib-db-manager"] | |||
| CMD ["-w", "kubernetes"] | |||
There was a problem hiding this comment.
Was this flag not used before?
There was a problem hiding this comment.
Thanks for the review! @johnugeorge
Yes, katib-db-manager can not recognize that flag.
$ docker run --platform linux/amd64 -it docker.io/kubeflowkatib/katib-db-manager:v1beta1-9c7d797 -w kubernetes
flag provided but not defined: -w
Usage of ./katib-db-manager:
tenzen-y
changed the title
tenzen-y
changed the title
|
Thanks @tenzen-y I see that it is overriden in manifests. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I added a flag,
--connect-timeout, to katib-db-manager that sets the time before calling an error on database connection and remove the non-configurable flag,-w kubernetes, set in katib-db-manager Dockerfile.Also, I fixed a process to set PostgreSQL Database.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1928
Checklist: