Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Tensorflow version #2079

Merged

Conversation

tenzen-y
Copy link
Member

Signed-off-by: Yuki Iwai [email protected]

What this PR does / why we need it:
I upgraded the Tensorflow version.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@@ -2,5 +2,4 @@ psutil==5.9.4
rfc3339>=6.2
grpcio==1.41.1
googleapis-common-protos==1.6.0
tensorflow==2.9.3; platform_machine=="x86_64"
tensorflow-aarch64==2.9.1; platform_machine=="aarch64"
tensorflow==2.11.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Tensorflow v2.10.0, the binary for aarch64 is shipped as tensorflow.

aarch64 CPUs: Experimental performance optimizations from Compute Library for the Arm® Architecture (ACL) are available through oneDNN in the default Linux aarch64 package (pip install tensorflow).

https://github.com/tensorflow/tensorflow/releases/tag/v2.10.0

@tenzen-y
Copy link
Member Author

I'm going to force-push to run failed jobs.

@tenzen-y tenzen-y changed the title Upgrade Tensorflow version [WIP] Upgrade Tensorflow version Jan 10, 2023
Copy link
Member

@anencore94 anencore94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@johnugeorge
Copy link
Member

Is this PR ready?

@tenzen-y
Copy link
Member Author

Is this PR ready?

No, I'm debugging the CI errors.

@@ -63,7 +63,7 @@
test_model = constructor.build_model()
test_model.summary()
test_model.compile(loss=keras.losses.categorical_crossentropy,
optimizer=keras.optimizers.Adam(learning_rate=1e-3, decay=1e-4),
optimizer=keras.optimizers.Adam(learning_rate=1e-3),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To resolve the following error:

Traceback (most recent call last):
  File "/opt/enas-cnn-cifar10/RunTrial.py", line 66, in <module>
    optimizer=keras.optimizers.Adam(learning_rate=1e-3, decay=1e-4),
  File "/usr/local/lib/python3.10/site-packages/keras/optimizers/optimizer_experimental/adam.py", line 104, in __init__
    super().__init__(
  File "/usr/local/lib/python3.10/site-packages/keras/optimizers/optimizer_experimental/optimizer.py", line 1053, in __init__
    super().__init__(
  File "/usr/local/lib/python3.10/site-packages/keras/optimizers/optimizer_experimental/optimizer.py", line 89, in __init__
    self._process_kwargs(kwargs)
  File "/usr/local/lib/python3.10/site-packages/keras/optimizers/optimizer_experimental/optimizer.py", line 118, in _process_kwargs
    raise ValueError(
ValueError: decay is deprecated in the new Keras optimizer, pleasecheck the docstring for valid arguments, or use the legacy optimizer, e.g., tf.keras.optimizers.legacy.Adam.

The decay for the learning rate was removed from the Adam optimizer.

@tenzen-y tenzen-y changed the title [WIP] Upgrade Tensorflow version Upgrade Tensorflow version Jan 10, 2023
@tenzen-y
Copy link
Member Author

@johnugeorge This PR is ready.

@johnugeorge
Copy link
Member

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnugeorge,tenzen-y]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit d76f01e into kubeflow:master Jan 11, 2023
@tenzen-y tenzen-y deleted the upgrade-tensorflow-version branch January 11, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants