Upgrade PyTorch version to v1.13.0 #2082
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
requested review from
anencore94,
gaocegege and
johnugeorge
|
It seems that |
|
@tenzen-y OOM Error is consistently happening |
Yes, that's right. I'm looking for a way to avoid OOM killed. |
|
/hold |
Signed-off-by: Yuki Iwai <[email protected]>
Signed-off-by: Yuki Iwai <[email protected]>
tenzen-y
force-pushed
the
upgrade-python-version
branch
from
5afd4cb
to
9e72267
Compare
|
|
||
| echo -e "\n\nLoading $CONTAINER_NAME image...\n\n" | ||
| minikube image load "$REGISTRY/$CONTAINER_NAME:$TAG" | ||
| DOCKER_BUILDKIT=1 minikube image build --build-opt platform=linux/amd64 --all -t "$REGISTRY/$CONTAINER_NAME:$TAG" -f "$DOCKERFILE" . |
There was a problem hiding this comment.
To avoid OOM errors in CI, we must build container images using minikube instead of docker.
There was a problem hiding this comment.
What is the difference here?
There was a problem hiding this comment.
The build succeeded but tests take longer time
There was a problem hiding this comment.
@johnugeorge In minikube image build, we can build images using an actual container runtime on the minikube cluster. So we no longer load images to the minikube cluster.
There was a problem hiding this comment.
|
LGTM /assign @andreyvelich |
|
/hold cancel |
|
Thank you for this improvement @tenzen-y ! |
Signed-off-by: Yuki Iwai [email protected]
What this PR does / why we need it:
I upgraded PyTorch version to v1.13.0.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Checklist: