Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat katib-operators #2114

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Feb 14, 2023

Signed-off-by: Yuki Iwai [email protected]

What this PR does / why we need it:
I reformated katib-operators with black operators/*/src.
This PR will fix the following error:

would reformat /home/runner/work/katib/katib/operators/katib-ui/src/charm.py

Oh no! 💥 💔 💥
1 file would be reformatted, 2 files would be left unchanged.
Error: Process completed with exit code 1.

https://github.com/kubeflow/katib/actions/runs/4173685371/jobs/7226319287

After:

$ black --check operators/*/src
All done! ✨ 🍰 ✨
3 files would be left unchanged.

Blocking: #2101

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Yuki Iwai <[email protected]>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member Author

/assign @andreyvelich

Also, can you restart failed Go Test / Unit Test (1.23.5) (pull_request)?

@tenzen-y
Copy link
Member Author

I will create a cherry-pick PR once this PR is merged.

@johnugeorge
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 14, 2023
@google-oss-prow google-oss-prow bot merged commit 0997566 into kubeflow:master Feb 14, 2023
@tenzen-y tenzen-y deleted the refotmat-katib-operators branch February 14, 2023 15:16
@tenzen-y tenzen-y restored the refotmat-katib-operators branch February 14, 2023 15:18
tenzen-y added a commit to tenzen-y/katib that referenced this pull request Feb 14, 2023
@tenzen-y tenzen-y deleted the refotmat-katib-operators branch February 14, 2023 15:29
google-oss-prow bot pushed a commit that referenced this pull request Feb 14, 2023
johnugeorge pushed a commit to johnugeorge/katib that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants