kwa(front): Support all namespaces #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
requested review from
anencore94,
johnugeorge and
kimwnasptd
|
The code looks good. I also tested the image in my cluster and works as expected. Thank you @elenzio9! |
|
/assign @kimwnasptd |
|
@tasos-ale could you take a stab at this? /cc @tasos-ale |
elenzio9
force-pushed
the
feature-elena-kwa-support-all-namespaces
branch
from
986e13a
to
db7785e
Compare
Add support for all-namespaces in KWA. Signed-off-by: Elena Zioga <[email protected]>
elenzio9
force-pushed
the
feature-elena-kwa-support-all-namespaces
branch
from
db7785e
to
318b35c
Compare
tasos-ale
approved these changes
Feb 22, 2023
|
Will go on and merge the CentralDashboard one as well kubeflow/kubeflow#6958 /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elenzio9, kimwnasptd, tasos-ale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for all-namespaces in KWA.
Related PR: kubeflow/kubeflow#6958