Replace action to setup minikube with medyagh/setup-minikube #2178
+40
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenzen-y
changed the title
tenzen-y
force-pushed
the
replace-minikube-setup
branch
6 times, most recently
from
9c10db9
to
623e6bf
Compare
6 tasks
| @@ -9,9 +9,6 @@ concurrency: | |||
| group: ${{ github.workflow }}-${{ github.ref }} | |||
| cancel-in-progress: true | |||
|
|
|||
| env: | |||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
|
|
|||
There was a problem hiding this comment.
Did we require GitHub Token before for our E2Es?
There was a problem hiding this comment.
Yes, the token is required for the manusa/actions-setup-minikube.
tenzen-y
force-pushed
the
replace-minikube-setup
branch
3 times, most recently
from
bc037e8
to
109caf8
Compare
Signed-off-by: Yuki Iwai <[email protected]>
tenzen-y
force-pushed
the
replace-minikube-setup
branch
from
109caf8
to
7430048
Compare
tenzen-y
changed the title
|
This PR is ready for review. Also, I confirmed this change is effective for k8s v1.26 at #2177. |
1 task
andreyvelich
approved these changes
Jul 31, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, gaocegege, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I replaced actions to set up minikube with medyagh/setup-minikube since using manusa/actions-setup-minikube seems to no longer be maintained, and the action doesn't support kubernetes v1.26.
related to: #2177
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Checklist: