Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main.go: Fix style #55

Merged
merged 1 commit into from
Apr 19, 2018
Merged

main.go: Fix style #55

merged 1 commit into from
Apr 19, 2018

Conversation

gaocegege
Copy link
Member

  • Remove the flag init since it is not used in the code
  • Remove the function spawn-worker since it is not used in the code
  • Fix some variable names

/assign @YujiOshima

Signed-off-by: Ce Gao [email protected]

Signed-off-by: Ce Gao <[email protected]>
@YujiOshima
Copy link
Contributor

/lgtm Thanks!

@YujiOshima
Copy link
Contributor

/approve

@gaocegege
Copy link
Member Author

/lgtm

@k8s-ci-robot
Copy link

@gaocegege: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YujiOshima,gaocegege]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member Author

It is weird, the tide is still pending although we approved the PR.

@gaocegege gaocegege merged commit eb61c8e into kubeflow:master Apr 19, 2018
@gaocegege gaocegege deleted the fix branch April 19, 2018 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants