Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set userid and group id in TF Serving GPU container #367

Closed
jlewi opened this issue Mar 6, 2018 · 0 comments
Closed

Set userid and group id in TF Serving GPU container #367

jlewi opened this issue Mar 6, 2018 · 0 comments
Assignees
@ankushagarwal
Labels
area/inference priority/p1

Comments

@jlewi
Copy link
Contributor

jlewi commented Mar 6, 2018

In the CPU container we create a user id and group id for user 1000 here
https://github.com/kubeflow/kubeflow/blob/master/components/k8s-model-server/images/Dockerfile.cpu#L53

We set that userid and groupid as part of the deployment here
https://github.com/kubeflow/kubeflow/blob/master/kubeflow/tf-serving/tf-serving.libsonnet#L143

We should probably do something similar for the GPU container. Otherwise I think users might have to override the securityContext in the deployment so as to avoid setting user id and group id.
@ankushagarwal ankushagarwal self-assigned this Mar 7, 2018
@ankushagarwal ankushagarwal mentioned this issue Mar 8, 2018
Merged
k8s-ci-robot pushed a commit that referenced this issue Mar 8, 2018
@k8s-ci-robot
Update tfserving gpu image to create model-server user (#390)
0dd764d 
Fixes #367
elenzio9 pushed a commit to arrikto/kubeflow that referenced this issue Oct 31, 2022
@jlewi
Autosync kubeflow.org groups using GitOps (kubeflow#367)
f6a6c0f 
* This is a replacement for shelling out to GAM.

* Import all the existing groups to YAML files.
  * Get rid of the old text files and GAM code

* Only import members for groups that already defined in GitHub
  * We don't want to be the ones putting people's emails into GitHub
  * As part of the migration we will ask members of groups not
    currently being auto-sync'd to open up PRs to add themselves
  * We will then enable AutoSync for all groups.
  * We import stubs for all Groups but disable auto-sync; this way
    we can start asking people to submit PRs to join the group before
    we turn on the sync.

* Support reading the OAuth2 credential from GCS
* Add a Makefile to make it easy to run the commands.

* Use a content hash to detect when files have changed and determine when to resync.

* Also periodically force a resync so if there is any drift due to changes
  made outside the system they are reverted.

Related to kubeflow/internal-acls#365 auto sync the Google groups

Co-authored-by: Jeremy Lewi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankushagarwal ankushagarwal

Labels
area/inference priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlewi @ankushagarwal