Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Kubeflow publish and maintain TF Serving Docker Images? #50

Closed
jlewi opened this issue Dec 20, 2017 · 6 comments
Closed

Should Kubeflow publish and maintain TF Serving Docker Images? #50

jlewi opened this issue Dec 20, 2017 · 6 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Dec 20, 2017

Opening this issue to consider whether Kubeflow should publish and curate TF Serving Docker images.

I think there is a reasonable expectation in the community that users shouldn't have to build Docker images just to serve models: see

A number of folks have already publicly shared Docker images (see tensorflow/serving#513), Kubeflow has also made a Docker image publicly available based on this Dockerfile

Kubeflow's ksonnet component for serving depends on having a publicly available Docker image to prevent customers from having to build their own image.

I think what's missing is a committement to maintaining and supporting these images. I think kubeflow should try to figure out what that would mean and whether we want to take that on.

Here are some questions to consider

  • Which versions of TensorFlow serving would we support?
  • What validation/verification of images we perform?
  • Would we provide GPU images?
  • Are there other artifacts we should release? e.g. the python client libraries for TF serving?

Initial proposal

  • We provide a Docker image for each TensorFlow Serving minor release
    • Starting with the current 1.4.0 release
  • We only provide an image for CPU

/cc @bhack @chrisolston @rhaertel80 @lluunn@nfiedel @bhupchan@ddysher

@jlewi jlewi changed the title Should Kubeflow publish and maintain TF Serving Docker Images Should Kubeflow publish and maintain TF Serving Docker Images? Dec 20, 2017
@bhack
Copy link

bhack commented Dec 20, 2017

Finally! /cc @nfiedel @bhupchan @ddysher

@sub-mod
Copy link

sub-mod commented Dec 20, 2017

I hope we support centos images as well.

As a sidenote wrt to tf-serving in openshift there exists

@bhack
Copy link

bhack commented Dec 20, 2017

If we want to start with CPU image what flags want we activate? Cause generally AVX etc.. are disabled.

@flx42
Copy link

flx42 commented Dec 20, 2017

What's the issue with providing a GPU image?
(at the risk of sounding like a broken record, it would be nice to have the same conversation for an "official" notebook image).

@jlewi
Copy link
Contributor Author

jlewi commented Dec 20, 2017

@flx42 Reason for trying to limit to CPU is just trying to scope work given staffing is very scarce and CPU is probably the more common case. If you or someone else wants to take the lead on providing a GPU image for TFServing; you'd have my full support.

I think there's some basic infrastructure we need to get into place for CI/CD of images. Once we have that in place hopefully we can add images to cover more use cases.

I'll open an issue to discuss official notebook images.

@jlewi jlewi added this to the Kubecon Europe milestone Jan 9, 2018
jlewi pushed a commit that referenced this issue Feb 6, 2018
We want to have a workflow that automatically build and push the TF serving image from source, and run some test against it to verify it's working.
Argo is suitable for this kind of workflows, and it supports docker in docker.

In this PR, the workflows contains building+pushing part. (will add testing in followup PR).
It's using the Dockerfile in components/k8s-model-server/docker, which is a TF1.4 CPU image.

Related #50
jlewi pushed a commit that referenced this issue Feb 16, 2018
Update the workflow for building TF serving image to 3 steps:

checkout
build and push the TF serving image
use the image to deploy tf-serving component
send prediction to it
For step 4, it needs tensorflow and tf serving api. Added a new Dockerfile, for tf-test-worker image.

* The test isn't integrated into our CI system yet.
* Related to #50
jlewi pushed a commit that referenced this issue Feb 24, 2018
pre/post-submit will also build / push / test TF serving image using the workflow in
components/k8s-model-server/images/releaser

The image name is gcr.io/mlkube-testing/model-server, and tag is the workflow name.

Related to #64  TFServing Uber Tracking Bug
Related to #50 Publish and maintain TFServing Docker images.
@jlewi
Copy link
Contributor Author

jlewi commented Feb 24, 2018

So we've decided that we need to publish and maintain Docker images to have a good experience. At least until TFServing takes this on.

Lets use the uber tracking bug #64. To track actual work.

@jlewi jlewi closed this as completed Feb 24, 2018
kimwnasptd pushed a commit to arrikto/kubeflow that referenced this issue Mar 5, 2019
* Add gojek dsp group email

To feast team members list. 
Ref Issue kubeflow#49

* Sort members alphabetically
yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Nov 1, 2019
* test_harness w/ fixes for the unit tests to pass

* update for README.md

* update to README.md

* added test harness files to generate unit tests
kimwnasptd pushed a commit to arrikto/kubeflow that referenced this issue May 27, 2021
The AuthService logout is implemented as follows:
1. Send POST request to logout endpoint with credentials in `Authorization:
Bearer <token>` header. The token is found in the cookie set by the authservice,
called `authservice_session`.
2. A successful response will have a status code of 201 and will return a JSON
response. The JSON response includes the URL to redirect to after logout.

This commit is a rebase of this original GH PR: kubeflow#50

Signed-off-by: Stefano Fioravanzo <[email protected]>
kimwnasptd pushed a commit to arrikto/kubeflow that referenced this issue Oct 6, 2021
The AuthService logout is implemented as follows:
1. Send POST request to logout endpoint with credentials in `Authorization:
Bearer <token>` header. The token is found in the cookie set by the authservice,
called `authservice_session`.
2. A successful response will have a status code of 201 and will return a JSON
response. The JSON response includes the URL to redirect to after logout.

This commit is a rebase of this original GH PR: kubeflow#50

Signed-off-by: Stefano Fioravanzo <[email protected]>
VaishnaviHire pushed a commit to VaishnaviHire/kubeflow that referenced this issue Apr 11, 2023
Add terminal activity to notebook controller culler logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants