Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a script to update some of the docker images in the prototypes #1063

Merged
merged 1 commit into from
Jun 28, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Jun 21, 2018

@pdmack
Copy link
Member

pdmack commented Jun 21, 2018

/approve
/lgtm

@pdmack
Copy link
Member

pdmack commented Jun 22, 2018

/retest

@jlewi
Copy link
Contributor Author

jlewi commented Jun 22, 2018

/approve

@pdmack
Copy link
Member

pdmack commented Jun 26, 2018

@jlewi needs rebase

@jlewi
Copy link
Contributor Author

jlewi commented Jun 28, 2018

Thanks PTAL.

@pdmack
Copy link
Member

pdmack commented Jun 28, 2018

/lgtm

@jlewi
Copy link
Contributor Author

jlewi commented Jun 28, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi, pdmack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 28fab67 into kubeflow:master Jun 28, 2018
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
* Init change

* Change hyperopt suggestion

* Generate new id in Trial loop

* Run tpe suggest for each Trial

* Move is first run
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
* For GCP will not be using KFDef with 1.1; instead we will be using
  blueprints (see kubeflow#1063)

* Therefore I updated the existing example of deploying using stacks
  to make it non GCP specific so that it could be used as an example
  for platforms that still want to use KFDef.

  * kubeflow#1062 is tracking migrating all KFDefs to the new versions
    of our kustomize packages
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
* Per kubeflow#1063 with 1.1 GCP will no longer use KFDef to deploy
  Kubeflow; isntead we will be using blueprints kubeflow/gcp-blueprints

  * So we remove all the GCP KFDefs

  * Cleanup the kfdef/OWNERs; remove Googlers since there are no longer
    anymore GCP configs.

* Fix kubeflow#818 - stop running E2E tests that deploy Kubeflow on every
  commit.

  * We now have unittests aimed at validating the manifests; so it
    no longer makes sense to fully deploy KF and verify its working.

    * E2E tests should now happen downstream.

    * We also need to remove the tests since we are removing GCP KFDefs on
      which they depend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants