-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds check to see if Katib is deployed and updates CentralUI accordingly. #1242
Conversation
/assign @kunmingg |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kunmingg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
fmt.Printf("Error in regexp") | ||
} | ||
|
||
katibpod := "vizier*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't understand the regexp syntax and matching. "*" denotes a zero or more occurrences. It matches on "vizie". It must be "^vizier", or better use strings.HasPrefix.
func example() {
r, _ := regexp.Compile("foo*")
fmt.Println(r.MatchString("food"))
fmt.Println(r.MatchString("seafood"))
fmt.Println(r.MatchString("info"))
fmt.Println(strings.HasPrefix("food", "foo"))
fmt.Println(strings.HasPrefix("seafood", "foo"))
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix accordingly
Will fix and update. Thank you for the review.
…On Wed, Aug 15, 2018 at 12:06 AM IWAMOTO Toshihiro ***@***.***> wrote:
***@***.**** commented on this pull request.
please fix accordingly
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1242 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AV9Rn438jA8TCTREcsP2DaRFOebIDX5Dks5uQ8iFgaJpZM4VW2Z->
.
|
This change is