Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds check to see if Katib is deployed and updates CentralUI accordingly. #1242

Merged
merged 2 commits into from
Jul 19, 2018

Conversation

swiftdiaries
Copy link
Member

@swiftdiaries swiftdiaries commented Jul 19, 2018

This change is Reviewable

@swiftdiaries
Copy link
Member Author

/assign @kunmingg

@kunmingg
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@swiftdiaries
Copy link
Member Author

/retest

fmt.Printf("Error in regexp")
}

katibpod := "vizier*"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't understand the regexp syntax and matching. "*" denotes a zero or more occurrences. It matches on "vizie". It must be "^vizier", or better use strings.HasPrefix.

func example() {
r, _ := regexp.Compile("foo*")

fmt.Println(r.MatchString("food"))
fmt.Println(r.MatchString("seafood"))
fmt.Println(r.MatchString("info"))
fmt.Println(strings.HasPrefix("food", "foo"))
fmt.Println(strings.HasPrefix("seafood", "foo"))

}

Copy link

@toshiiw toshiiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix accordingly

@swiftdiaries
Copy link
Member Author

swiftdiaries commented Aug 15, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants