Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope kubeflow prow jobs by job type and modified dirs #1244

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

richardsliu
Copy link
Contributor

@richardsliu richardsliu commented Jul 19, 2018

Scoping the kubeflow workflows such that:

  • GKE is run on pre and postsubmit jobs
  • Minikube is only run on postsubmit jobs
  • TF-serving-image is only run when tf-serving directory is modified

Fix kubeflow/testing#150


This change is Reviewable

@richardsliu
Copy link
Contributor Author

/assign @jlewi

@jlewi
Copy link
Contributor

jlewi commented Jul 20, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4986c55 into kubeflow:master Jul 20, 2018
@richardsliu richardsliu deleted the kubeflow_prow_config branch August 10, 2018 23:48
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants