Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes 'ksonnet namespace should be retrieved from env not params' #1829

Merged
merged 2 commits into from
Oct 19, 2018
Merged

fixes 'ksonnet namespace should be retrieved from env not params' #1829

merged 2 commits into from
Oct 19, 2018

Conversation

kkasravi
Copy link
Contributor

@kkasravi kkasravi commented Oct 19, 2018 •
edited by jlewi
Loading

fixes #1825

This change is Reviewable

@kkasravi
Copy link
Contributor Author

/assign @jlew @swiftdiaries @lluunn

@k8s-ci-robot
Copy link
Contributor

@kkasravi: GitHub didn't allow me to assign the following users: jlew.

Note that only kubeflow members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @jlew @swiftdiaries @lluunn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lluunn
Copy link
Contributor

lluunn commented Oct 19, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lluunn
Copy link
Contributor

lluunn commented Oct 19, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 935cf41 into kubeflow:master Oct 19, 2018
@richardsliu richardsliu mentioned this pull request Oct 25, 2018
Merged
@dsdinter dsdinter mentioned this pull request Nov 28, 2018
Closed
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
@kkasravi @k8s-ci-robot
fixes 'ksonnet namespace should be retrieved from env not params' (ku…
ee72474 
…beflow#1829)

* fixes 'ksonnet namespace should be retrieved from env not params'

* /retest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alsrgv alsrgv Awaiting requested review from alsrgv

@gaocegege gaocegege Awaiting requested review from gaocegege

Assignees

@swiftdiaries swiftdiaries

@lluunn lluunn

Labels
approved cla: yes lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ksonnet namespace should be retrieved from env not params
5 participants
@kkasravi @k8s-ci-robot @lluunn @googlebot @swiftdiaries