Separate logic for setup_backend.sh #1841
Conversation
r2d4
force-pushed
the
single-service-backend
branch
from
6f6fc32
to
5a79653
Compare
r2d4
changed the title
kubeflow/core/pod.yaml
Outdated
| @@ -0,0 +1,36 @@ | |||
| apiVersion: v1 | |||
There was a problem hiding this comment.
What's this for? Aren't use using the K8s job in iap.libsonnet to run update_backend.sh?
scripts/util.sh
Outdated
| @@ -76,7 +76,7 @@ function createKsApp() { | |||
| # ks component rm spartakus | |||
| # Generate a random 30 bit number | |||
| local usageId=$(((RANDOM<<15)|RANDOM)) | |||
| ks generate spartakus spartakus --usageId=${usageId} --reportUsage=true | |||
| # ks generate spartakus spartakus --usageId=${usageId} --reportUsage=true | |||
There was a problem hiding this comment.
Did you intend to comment this out?
|
Thanks @r2d4 You should be able to follow these instructions to get the logs for the Argo step that failed in your most recent presubmit However, the reason the logs don't show up in Argo is probably just a transient error; so its likely if you rerun the tests the Argo logs will be available and you can see the failure that way. |
|
@r2d4 ping? Is this blocked on anything if not would be good to get it updated and submitted? |
"setup_backend.sh is doing two things 1. updating the backend service 2. updating the envoy config in each instance with the info needed for JWT validation " This PR separates those two concerns into two separate scripts. mount file wip
r2d4
force-pushed
the
single-service-backend
branch
from
5a79653
to
1c6ad48
Compare
|
cc @jlewi this should be ready for review |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
"setup_backend.sh is doing two things 1. updating the backend service 2. updating the envoy config in each instance with the info needed for JWT validation " This PR separates those two concerns into two separate scripts. mount file wip
…#1841) The current section for connecting to a Kubeflow cluster only covers connecting with port-forward. Expand the section with instructions for NodePort / LoadBalancer / Ingress. Signed-off-by: Yannis Zarkadas <[email protected]>
"setup_backend.sh is doing two things
JWT validation
"
This PR separates those two concerns into two separate scripts.
Fixes #1145
This change is