-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base href for correct link in Argo UI #1865
Conversation
/retest |
2 similar comments
/retest |
/retest |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
7f2c21e
to
4334bd6
Compare
CLAs look good, thanks! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kunmingg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
* Added BaseHref for correct link in Argo UI * Formatted libsonnet
@andreyvelich just like to confirm this PR will only work behind Ambassador? If I install argo individually, this will not work. |
@Jeffwan Yes, that's true. Right now Argo UI only supports work behind Ambassador. |
Cool. Thanks for the confirmation. @andreyvelich |
* Added BaseHref for correct link in Argo UI * Formatted libsonnet
Fixes #1694
This change is