Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IronPan to pipeline ks package owner #1980

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Conversation

IronPan
Copy link
Member

@IronPan IronPan commented Nov 21, 2018

This change is Reviewable

Copy link
Contributor

@k8s-ci-robot k8s-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IronPan: 1 invalid OWNERS file

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -0,0 +1,3 @@
approvers:
- IronPan
reviewers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: error converting YAML to JSON: yaml: line 3: could not find expected ':'.

Copy link
Member

@abhi-g abhi-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhi-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f24bdf8 into kubeflow:master Nov 21, 2018
r2d4 pushed a commit to r2d4/kubeflow that referenced this pull request Nov 26, 2018
* Add IronPan to pipeline ks package owner

* Update OWNERS
@r2d4 r2d4 mentioned this pull request Nov 26, 2018
k8s-ci-robot pushed a commit that referenced this pull request Nov 26, 2018
* Add IronPan as Argo owner (#1974)

* initial change - add pipeline entry to kubeflow registry (#1973)

* add pipeline entry

* use camel case for params

* formatting

* format

* fix

* remove spartakus

* Add IronPan to pipeline ks package owner (#1980)

* Add IronPan to pipeline ks package owner

* Update OWNERS

* cherry-pick pipeline component onto 0.3-branch

* remove travis config (#1790)
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* Add IronPan to pipeline ks package owner

* Update OWNERS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants