sync-notebook needs to look for a Deployment kind that is version independent

[stpabhi]

Signed-off-by: Abhilash Pallerlamudi [email protected]

Fix #2185

Problem: Metacontroller deletes notebook deployment if there is a version mismatch between the Deployment created and the Deployment specified.

Fix: sync-notebook needs to look for a Deployment kind that is version independent.

Details: #2185 (comment)

---

This change is 

[k8s-ci-robot]

Hi @stpabhi. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jlewi]

/ok-to-test

Thanks for the fix.

@stpabhi Can you update the PR description to explain what the problem is and how this fixes it?

/assign @jlewi
/assign @kkasravi

[kkasravi]

@jlewi both this and #2154 should be merged since they are correctly returning the children created by a controller during sync (every 20sec). Profiles/Permission controllers also need something similar.

[jlewi]

Thanks @kkasravi I reviewed #2154

[jlewi]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• kubeflow/common/OWNERS [jlewi]
• kubeflow/jupyter/OWNERS [jlewi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment