argo s3 artifact repository configuration added #2238
Conversation
|
Hi @pbrzostowski. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pbrzostowski
force-pushed
the
argo-s3-repository
branch
from
76e1386
to
28f4dc4
Compare
|
/ok-to-test |
|
Ooops @pbrzostowski, can you please update your PR after running |
pbrzostowski
force-pushed
the
argo-s3-repository
branch
from
28f4dc4
to
2405154
Compare
|
@pdmack sure, wasn't aware of this. I've just pushed my changes. |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pdmack The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
It seem argo is not taking the default artifact repo from the config map: argoproj/argo-workflows#1056 |
…ine packages We should follow Argo's prefferred way to configure the artifact storage: https://github.com/argoproj/argo/blob/master/ARTIFACT_REPO.md#configure-the-default-artifact-repository and use a cluster-local configMap. This way the pipelines remain clean and portable: https://github.com/argoproj/argo/blob/master/examples/artifact-passing.yaml Kubeflow deployer has already been pre-installing the configMap for several months: kubeflow/kubeflow#2238
…ine packages We should follow Argo's prefferred way to configure the artifact storage: https://github.com/argoproj/argo/blob/master/ARTIFACT_REPO.md#configure-the-default-artifact-repository and use a cluster-local configMap. This way the pipelines remain clean and portable: https://github.com/argoproj/argo/blob/master/examples/artifact-passing.yaml Kubeflow deployer has already been pre-installing the configMap for several months: kubeflow/kubeflow#2238
…ine packages We should follow Argo's prefferred way to configure the artifact storage: https://github.com/argoproj/argo/blob/master/ARTIFACT_REPO.md#configure-the-default-artifact-repository and use a cluster-local configMap. This way the pipelines remain clean and portable: https://github.com/argoproj/argo/blob/master/examples/artifact-passing.yaml Kubeflow deployer has already been pre-installing the configMap for several months: kubeflow/kubeflow#2238
…ine packages (#1297) We should follow Argo's prefferred way to configure the artifact storage: https://github.com/argoproj/argo/blob/master/ARTIFACT_REPO.md#configure-the-default-artifact-repository and use a cluster-local configMap. This way the pipelines remain clean and portable: https://github.com/argoproj/argo/blob/master/examples/artifact-passing.yaml Kubeflow deployer has already been pre-installing the configMap for several months: kubeflow/kubeflow#2238
Now Argo deployed with with
kfctl.shcannot handle workflows with artifactory configuration.This PR updating Argo ksonnet configuration to include s3 minio repository in workflow controller configmap.
This change is