Update argo artifact repo secret name (#198)

* Update argo artifact repo secret name This is to align with https://github.com/kubeflow/kubeflow/blob/8a01606dc43b217a221eaf2fea2a8207d72ad75d/kubeflow/argo/prototypes/argo.jsonnet#L13 Fix #193 * Update argo-base_test.go * Update argo-overlays-istio_test.go
kubeflow · Jul 3, 2019 · 1868812 · 1868812
1 parent 7cf5587
commit 1868812
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/argo/base/params.env b/argo/base/params.env
@@ -4,8 +4,8 @@ artifactRepositoryBucket=mlpipeline
 artifactRepositoryKeyPrefix=artifacts
 artifactRepositoryEndpoint=minio-service.kubeflow:9000
 artifactRepositoryInsecure=true
-artifactRepositoryAccessKeySecretName=minio-artifact
+artifactRepositoryAccessKeySecretName=mlpipeline-minio-artifact
 artifactRepositoryAccessKeySecretKey=accesskey
-artifactRepositorySecretKeySecretName=minio-artifact
+artifactRepositorySecretKeySecretName=mlpipeline-minio-artifact
 artifactRepositorySecretKeySecretKey=secretkey
 clusterDomain=cluster.local
diff --git a/tests/argo-base_test.go b/tests/argo-base_test.go
@@ -329,9 +329,9 @@ artifactRepositoryBucket=mlpipeline
 artifactRepositoryKeyPrefix=artifacts
 artifactRepositoryEndpoint=minio-service.kubeflow:9000
 artifactRepositoryInsecure=true
-artifactRepositoryAccessKeySecretName=minio-artifact
+artifactRepositoryAccessKeySecretName=mlpipeline-minio-artifact
 artifactRepositoryAccessKeySecretKey=accesskey
-artifactRepositorySecretKeySecretName=minio-artifact
+artifactRepositorySecretKeySecretName=mlpipeline-minio-artifact
 artifactRepositorySecretKeySecretKey=secretkey
 clusterDomain=cluster.local
 `)

diff --git a/tests/argo-overlays-istio_test.go b/tests/argo-overlays-istio_test.go
@@ -366,9 +366,9 @@ artifactRepositoryBucket=mlpipeline
 artifactRepositoryKeyPrefix=artifacts
 artifactRepositoryEndpoint=minio-service.kubeflow:9000
 artifactRepositoryInsecure=true
-artifactRepositoryAccessKeySecretName=minio-artifact
+artifactRepositoryAccessKeySecretName=mlpipeline-minio-artifact
 artifactRepositoryAccessKeySecretKey=accesskey
-artifactRepositorySecretKeySecretName=minio-artifact
+artifactRepositorySecretKeySecretName=mlpipeline-minio-artifact
 artifactRepositorySecretKeySecretKey=secretkey
 clusterDomain=cluster.local
 `)