Correct XGBoostJob CRD group name and add singular name (#1313)

* Correct XGBoostJob CRD group name and add singular name * Fx Signed-off-by: terrytangyuan <[email protected]>
kubeflow · Jun 23, 2020 · e15922e · e15922e
1 parent d56e17c
commit e15922e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/xgboost-job/xgboost-operator/base/cluster-role.yaml b/xgboost-job/xgboost-operator/base/cluster-role.yaml
@@ -17,7 +17,7 @@ rules:
   - patch
   - delete
 - apiGroups:
-  - xgboostjob.kubeflow.org
+  - kubeflow.org
   resources:
   - xgboostjobs
   - xgboostjobs/status

diff --git a/xgboost-job/xgboost-operator/base/crd.yaml b/xgboost-job/xgboost-operator/base/crd.yaml
@@ -1,11 +1,12 @@
 apiVersion: apiextensions.k8s.io/v1beta1
 kind: CustomResourceDefinition
 metadata:
-  name: xgboostjobs.xgboostjob.kubeflow.org
+  name: xgboostjobs.kubeflow.org
 spec:
-  group: xgboostjob.kubeflow.org
+  group: kubeflow.org
   names:
     kind: XGBoostJob
+    singular: xgboostjob
     plural: xgboostjobs
   scope: Namespaced
   validation:

diff --git a/xgboost-job/xgboost-operator/overlays/application/application.yaml b/xgboost-job/xgboost-operator/overlays/application/application.yaml
@@ -17,7 +17,7 @@ spec:
     kind: Deployment
   - group: core
     kind: ServiceAccount
-  - group: xgboostjob.kubeflow.org
+  - group: kubeflow.org
     kind: XGBoostJob
   descriptor: 
     type: xgboostjob