Add AWS specific Container Image into jupyter-web-app configMap #1125
Assignees
Comments
|
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
|
/assign /priority p1 |
1 task
jlewi
pushed a commit
to jlewi/manifests
that referenced
this issue
Apr 24, 2020
* To fix the race condition with certmanager (kubeflow#1125) we move the KF issuer into a separate package from the package deploying kubeflow. This way we can wait for cert-manager to start before deploying resources. * Labels need to be immutable otherwise upgrades won't work (see kubeflow#1131). So remove version number from common labels and application selector so that apply will work to update resources.
k8s-ci-robot
pushed a commit
that referenced
this issue
Apr 30, 2020
* To fix the race condition with certmanager (#1125) we move the KF issuer into a separate package from the package deploying kubeflow. This way we can wait for cert-manager to start before deploying resources. * Labels need to be immutable otherwise upgrades won't work (see #1131). So remove version number from common labels and application selector so that apply will work to update resources.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue
Per AWS users' requirements, we want to add aws specific container image into jupyter-web-app confiMap.
Action Item
We'll create an overlay in
jupyter-web-app/overlayfolder, and patch jupyter-web-app confiMap with our awsnotebookimage. Meanwhile we'll modifykfctl_aws.v1.0.2.yaml,kfctl_aws.v1.0.1.yaml,and
kfctl_aws.v1.0.0.yaml, etc. This will make our users use aws supported image when creating KubeflowNotebookServer.I'll file a PR for this issue later.
/cc @Jeffwan @jlewi @richardsliu
The text was updated successfully, but these errors were encountered: