Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kustomize 5 warning for /common/istio-1-16/istio-install/ #2418

Closed
annajung opened this issue Mar 23, 2023 · 7 comments · Fixed by #2537
Closed

Fix kustomize 5 warning for /common/istio-1-16/istio-install/ #2418

annajung opened this issue Mar 23, 2023 · 7 comments · Fixed by #2537
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@annajung
Copy link
Member

annajung commented Mar 23, 2023

Part of #2388 to support kustomize 5 without warnings. Fix the use of deprecated fields in manifests/common/istio-1-16/istio-install/

Steps To Reproduce

  1. Download kustomize 5.0.0

  2. Run kustomize build using version kustomize 5.0.0 to see the warning

git clone https://github.com/kubeflow/manifests.git
cd manifests/common/istio-1-16/istio-install/base
kustomize build . > tmp.yaml

Current Behavior

Step 2 produces the following warning

# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

Expected Behavior

Step 2 completes without a warning and produces the same yaml as before the changes

Helpful links:

Where does the fix belong?

/common directory is managed by the Manifest WG, PR should be made to the manifests repo

/help
/good-first-issue

@google-oss-prow
Copy link

@annajung:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Part of #2388 to support kustomize 5. Fix the use of deprecated fields in manifests/common/istio-1-16/istio-install/

Steps To Reproduce

  1. Download kustomize 5.0.0

  2. Run kustomize build using version kustomize 5.0.0 to see the warning

git clone https://github.com/kubeflow/manifests.git
cd manifests/common/istio-1-16/istio-install/base
kustomize build . > tmp.yaml

Current Behavior

Step 2 produces the following warning

# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

Expected Behavior

Step 2 completes without a warning and produces the same yaml as before the changes

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 23, 2023
@annajung
Copy link
Member Author

/triage accepted

@google-oss-prow
Copy link

@annajung: The label(s) triage/accepted cannot be applied, because the repository doesn't have them.

In response to this:

/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@juliusvonkohout
Copy link
Member

We should rather delete 1.16 and check 1.17

@juliusvonkohout
Copy link
Member

But let us merge #2455 first. Afterwards just ping me and i can fix it.

@juliusvonkohout
Copy link
Member

/assign @juliusvonkohout

@juliusvonkohout
Copy link
Member

Fixed by #2537 . Please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
2 participants