-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kustomize 5 warning for /common/istio-1-16/istio-install/ #2418
Comments
@annajung: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/triage accepted |
@annajung: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We should rather delete 1.16 and check 1.17 |
But let us merge #2455 first. Afterwards just ping me and i can fix it. |
/assign @juliusvonkohout |
Fixed by #2537 . Please review |
Part of #2388 to support kustomize 5 without warnings. Fix the use of deprecated fields in
manifests/common/istio-1-16/istio-install/
Steps To Reproduce
Download kustomize 5.0.0
Run
kustomize build
using version kustomize 5.0.0 to see the warningCurrent Behavior
Step 2 produces the following warning
Expected Behavior
Step 2 completes without a warning and produces the same yaml as before the changes
Helpful links:
Where does the fix belong?
/common
directory is managed by the Manifest WG, PR should be made to the manifests repo/help
/good-first-issue
The text was updated successfully, but these errors were encountered: