Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ml-pipeline component for kustomize5 #2548

Closed
rawc0der opened this issue Oct 12, 2023 · 5 comments
Closed

Refactor ml-pipeline component for kustomize5 #2548

rawc0der opened this issue Oct 12, 2023 · 5 comments

Comments

@rawc0der
Copy link
Member

rawc0der commented Oct 12, 2023

Part of the larger #2388 initiative to refactor Kubeflow apps for kustomize5.
This Issue should address fixes for the deprecated fields for the manifests/apps/pipeline/ component.

Warnings thrown before this PR:

$ kustomize build apps/pipeline/upstream/env/cert-manager/platform-agnostic-multi-user/  

# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesJson6902' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'bases' is deprecated. Please use 'resources' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesStrategicMerge' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
2023/10/12 15:10:41 well-defined vars that were never replaced: kfp-app-name,kfp-app-version

Expected behaviour after refactoring the resources for kustomize is to obtain healthy set of manifests without any warnings.

Remaining Warnings (Work in progress):

 Warning: 'vars' is deprecated. Please use 'replacements' instead. [EXPERIMENTAL] Run 'kustomize edit fix' to update your Kustomization automatically.
# Warning: 'patchesJson6902' is deprecated. Please use 'patches' instead. Run 'kustomize edit fix' to update your Kustomization automatically.
2023/10/12 15:50:46 well-defined vars that were never replaced: kfp-app-version,kfp-app-name

After couple more commits I am expecting to have also refactored the remaining vars and patchesJson6902 deprecations from the rest of the resources.

Looking for feedback and a review! (@juliusvonkohout @annajung)

@rawc0der
Copy link
Member Author

This PR should be linked to kubeflow/pipelines#10053 as well.

@juliusvonkohout
Copy link
Member

kubeflow/pipelines#10087 is the new PR

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Jan 22, 2024

/close
since this is tracked in KFP

@juliusvonkohout
Copy link
Member

/close

Copy link

@juliusvonkohout: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants