Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipelines: fix pipeline minio secret name #194

Closed
wants to merge 1 commit into from
Closed

pipelines: fix pipeline minio secret name #194

wants to merge 1 commit into from

Conversation

yanniszark
Copy link
Contributor

@yanniszark yanniszark commented Jul 3, 2019

Fixes: #193

cc @jlewi please confirm it fixes your issue. I also bumped into this.

Signed-off-by: Yannis Zarkadas [email protected]


This change is Reviewable

Signed-off-by: Yannis Zarkadas <[email protected]>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign yanniszark
You can assign the PR to them by writing /assign @yanniszark in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@yanniszark: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-manifests-presubmit 9e980dc link /test kubeflow-manifests-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@IronPan
Copy link
Member

IronPan commented Jul 3, 2019

There are copies of this config in other places
https://github.com/kubeflow/pipelines/blob/master/manifests/base/argo/workflow-controller-configmap.yaml
https://github.com/kubeflow/kubeflow/blob/master/kubeflow/argo/prototypes/argo.jsonnet#L13

Eventually they will converge. For now I recommend keep the config same and close this PR.
#198 will fix the argo configmap

@Bobgy
Copy link
Contributor

Bobgy commented Oct 30, 2019

/close
To clean up open PRs, the issue has already been fixed by #198

@k8s-ci-robot
Copy link
Contributor

@Bobgy: Closed this PR.

In response to this:

/close
To clean up open PRs, the issue has already been fixed by #198

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Tomcli pushed a commit to Tomcli/manifests that referenced this pull request Dec 11, 2020
* further big_data_passing fixes after PR kubeflow#166

* further big_data_passing fixes after PR kubeflow#166

* address comments from reviewers

* Address comments form Tomcli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline minio artifact secret - named mlpipeline-minio-artifact; workflow expects minio-artifact
4 participants