-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jupyter-web-app with rbac.authorization.k8s.io/v1 #2035
Update jupyter-web-app with rbac.authorization.k8s.io/v1 #2035
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mvoitko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mvoitko. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
3b1b67f
to
366806b
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mvoitko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Max Voitko <[email protected]> Signed-off-by: Maksym Voitko <[email protected]>
366806b
to
f1ed26b
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions. |
@yanniszark could you please approve? |
Could anyone review please? |
It seems that you are in the wrong repository. You need to fix this in kubeflow/kubeflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@Arhell could you please approve? |
/test all |
https://github.com/kubeflow/manifests/blob/master/OWNERS#L1 |
@PatrickXYS could you please approve? |
You are in the wrong repository. If you ignore my help again it is your problem. Your changes belong here https://github.com/kubeflow/kubeflow/tree/master/components/crud-web-apps/jupyter/manifests/base Buf if you would have checked that you would have seen that it is already fixed and will me synchronized to kubeflow/manifests for 1.6 So just close this non-issue. If you want to get approved you should rather have 10-20 merged PRs. and important issues You can also attend the kubeflow and KFP community meetings |
@juliusvonkohout Thank you for the details! It would be also nice if this "If you want to get approved you should rather have 10-20 merged PRs." was explicitly mentioned in the internal acl. Getting to the point of the issue. I still don't understand why there is code duplication. In Kubeflow 1.5 the manifests are applied from this repo. Why couldn't we update them here? |
That is just the development structure. Each subgroup develops independently and prepares for the next release. Then their manifests get pulled into this meta repository. |
|
No, just close this and wait for #2200 (comment) |
Description of your changes:
The rbac.authorization.k8s.io/v1beta1 API version of ClusterRole, ClusterRoleBinding, Role, and RoleBinding is no longer served as of v1.22.
Migrate manifests and API clients to use the rbac.authorization.k8s.io/v1 API version, available since v1.8.
All existing persisted objects are accessible via the new APIs
No notable changes
https://kubernetes.io/docs/reference/using-api/deprecation-guide/#rbac-resources-v122