Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jupyter-web-app with rbac.authorization.k8s.io/v1 #2035

Conversation

mvoitko
Copy link
Contributor

@mvoitko mvoitko commented Sep 22, 2021

Description of your changes:
The rbac.authorization.k8s.io/v1beta1 API version of ClusterRole, ClusterRoleBinding, Role, and RoleBinding is no longer served as of v1.22.

Migrate manifests and API clients to use the rbac.authorization.k8s.io/v1 API version, available since v1.8.
All existing persisted objects are accessible via the new APIs
No notable changes
https://kubernetes.io/docs/reference/using-api/deprecation-guide/#rbac-resources-v122

@google-cla
Copy link

google-cla bot commented Sep 22, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mvoitko
To complete the pull request process, please assign patrickxys after the PR has been reviewed.
You can assign the PR to them by writing /assign @patrickxys in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aws-kf-ci-bot
Copy link

Hi @mvoitko. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mvoitko
Copy link
Contributor Author

mvoitko commented Sep 23, 2021

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Sep 23, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@mvoitko mvoitko force-pushed the feature/update-jupyter-web-app-rbac-api-version branch from 3b1b67f to 366806b Compare January 24, 2022 23:27
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mvoitko
To complete the pull request process, please assign patrickxys after the PR has been reviewed.
You can assign the PR to them by writing /assign @patrickxys in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Max Voitko <[email protected]>
Signed-off-by: Maksym Voitko <[email protected]>
@mvoitko mvoitko force-pushed the feature/update-jupyter-web-app-rbac-api-version branch from 366806b to f1ed26b Compare January 24, 2022 23:29
@google-cla google-cla bot added cla: yes and removed cla: no labels Jan 24, 2022
@stale
Copy link

stale bot commented Apr 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions.

@mvoitko
Copy link
Contributor Author

mvoitko commented May 10, 2022

@yanniszark could you please approve?

@stale stale bot removed the lifecycle/stale label May 10, 2022
@mvoitko
Copy link
Contributor Author

mvoitko commented Jun 23, 2022

Could anyone review please?

@juliusvonkohout
Copy link
Member

It seems that you are in the wrong repository. You need to fix this in kubeflow/kubeflow

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@mvoitko
Copy link
Contributor Author

mvoitko commented Jun 29, 2022

@Arhell could you please approve?

@mvoitko
Copy link
Contributor Author

mvoitko commented Jun 29, 2022

/test all

@Arhell
Copy link
Member

Arhell commented Jun 29, 2022

@mvoitko
Copy link
Contributor Author

mvoitko commented Jun 29, 2022

@PatrickXYS could you please approve?

@juliusvonkohout
Copy link
Member

@mvoitko

You are in the wrong repository. If you ignore my help again it is your problem. Your changes belong here https://github.com/kubeflow/kubeflow/tree/master/components/crud-web-apps/jupyter/manifests/base Buf if you would have checked that you would have seen that it is already fixed and will me synchronized to kubeflow/manifests for 1.6

So just close this non-issue. If you want to get approved you should rather have 10-20 merged PRs.
if you want to help here are some big PRs to review
kubeflow/pipelines#7819
kubeflow/pipelines#7938
kubeflow/pipelines#7725

and important issues
kubeflow/pipelines#4790

You can also attend the kubeflow and KFP community meetings

@mvoitko
Copy link
Contributor Author

mvoitko commented Jun 29, 2022

@juliusvonkohout Thank you for the details! It would be also nice if this "If you want to get approved you should rather have 10-20 merged PRs." was explicitly mentioned in the internal acl.

Getting to the point of the issue. I still don't understand why there is code duplication. In Kubeflow 1.5 the manifests are applied from this repo. Why couldn't we update them here?

@juliusvonkohout
Copy link
Member

@juliusvonkohout Thank you for the details! I still don't understand why there is code duplication. In Kubeflow 1.5 the manifests are applied from this repo. Why couldn't we update them here?

That is just the development structure. Each subgroup develops independently and prepares for the next release. Then their manifests get pulled into this meta repository.

@mvoitko
Copy link
Contributor Author

mvoitko commented Jun 29, 2022

That is just the development structure. Each subgroup develops independently and prepares for the next release. Then their manifests get pulled into this meta repository.
Oh. Cool. Thanks for the explanation. It wasn't obvious. Why are git submodules not used for this purpose instead of copy-paste?
So can I update the jupyter web app manifests for kubeflow 1.5?

@juliusvonkohout
Copy link
Member

No, just close this and wait for #2200 (comment)
You can also find me on the kubeflow slack channel https://kubeflow.slack.com/ssb/redirect

@mvoitko mvoitko closed this Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants