Fix typo in Katib GH action #2271
Conversation
| @@ -35,6 +35,6 @@ jobs: | |||
|
|
|||
| - name: Create katib experiment | |||
| run: | | |||
| kubectl apply -f tests/gh-actions/katib_test.yaml | |||
| kubectl apply -f tests/gh-actions/kf-objects/katib_test.yaml | |||
There was a problem hiding this comment.
Looks like the resources are created under kubeflow-user namespace which is not created before. In addition, it looks for a label to be enabled to create the experiment.
Running the follow commands before applying this yaml file made it work for me. Otherwise, it will throw an error for missing namespace
kubectl create namespace kubeflow-user
kubectl label namespace kubeflow-user katib.kubeflow.org/metrics-collector-injection=enabled
There was a problem hiding this comment.
Good catch! I'll send a follow up PR asap to fix this
NickLoukas
force-pushed
the
nickloukas-gh-action-apply-katib-fix
branch
from
2e2e4f1
to
276839c
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd, NickLoukas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Fix typo in Katib GH action. * Create kubeflow-user namespace before starting the katib experiment.
This is a follow up PR to this (#2249) to fix the path of the katib test.
Refs #2248