Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unmaintained notice to contrib spark #2320

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

annajung
Copy link
Member

Signed-off-by: Anna Jung (VMware) [email protected]

Which issue is resolved by this Pull Request:
Part of #2311

Description of your changes:
Add README to /contrib/spark to mark the directory as unmaintained and out of date

Note:
Tagging spark component owners @Jeffwan @holdenk to ensure awareness of the out-of-date label on the component.

To remove the unmaintained label, check out the missing requirements #2311 and leave a comment on the issue to indicate that you'll take action to provide the missing requirements and are willing to keep the component up to date.

cc @kimwnasptd @kubeflow/wg-manifests-leads

Signed-off-by: Anna Jung (VMware) <[email protected]>
@holdenk
Copy link
Contributor

holdenk commented Nov 28, 2022

/approve +1 no longer maintaned

@annajung
Copy link
Member Author

annajung commented Dec 1, 2022

cc @kimwnasptd can you take a look? with @holdenk's approval, I think we can get this merged.

@annajung
Copy link
Member Author

@kimwnasptd looking for your review! thanks

@kimwnasptd
Copy link
Member

kimwnasptd commented Jan 17, 2023

Apologies for the delay, looks good! Also, thank you for your time on this @holdenk. Hopefully, in the future, we can get a more solid integration story around Kubeflow and Spark and contributors to help maintain it.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annajung, holdenk, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 943be75 into kubeflow:master Jan 17, 2023
kevin85421 pushed a commit to juliusvonkohout/manifests that referenced this pull request Feb 28, 2023
Signed-off-by: Anna Jung (VMware) <[email protected]>

Signed-off-by: Anna Jung (VMware) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants