Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubeflow/katib manifests from v0.15.0-rc.0 #2367

Conversation

DomFleischmann
Copy link
Contributor

Update Katib manifests to v0.15.0-rc0.

@johnugeorge @andreyvelich @kimwnasptd

README.md Outdated
@@ -50,7 +50,7 @@ This repo periodically syncs all official Kubeflow components from their respect
| Jupyter Web App | apps/jupyter/jupyter-web-app/upstream | [v1.6.0-rc.1](https://github.com/kubeflow/kubeflow/tree/v1.6.0-rc.1/components/crud-web-apps/jupyter/manifests) |
| Tensorboards Web App | apps/tensorboard/tensorboards-web-app/upstream | [v1.6.0-rc.1](https://github.com/kubeflow/kubeflow/tree/v1.6.0-rc.1/components/crud-web-apps/tensorboards/manifests) |
| Volumes Web App | apps/volumes-web-app/upstream | [v1.6.0-rc.1](https://github.com/kubeflow/kubeflow/tree/v1.6.0-rc.1/components/crud-web-apps/volumes/manifests) |
| Katib | apps/katib/upstream | [v0.14.0-rc.0](https://github.com/kubeflow/katib/tree/v0.14.0-rc.0/manifests/v1beta1) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we update the images in the master after the v0.14.0 release ? When do we branch out in manifests repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't update them back in the master branch. The long term goal is to start using the manifests from master branch in other repos in Manifests, but haven't gotten to it yet.

@kimwnasptd
Copy link
Member

Looks like the GH Action is still failing in the KinD cluster with Katib's mysql Pod, like in the previous release #2273

Will take a look. But most probably we might merge this PR even though the action is failing for now

@DomFleischmann
Copy link
Contributor Author

@kimwnasptd if you believe that this has to do with the GH Action I'm okay with merging this

@kimwnasptd
Copy link
Member

@DomFleischmann could you rebase on top of the latest master to resolve the conflicts?

I'll also run the test we have locally. I remember that this would succeed in my laptop, and we had the hunch that this had to do with the GH Action VM. If it works locally I'll merge this manually and look at the test orthogonally

@DomFleischmann DomFleischmann force-pushed the sync-kubeflow-katib-manifests-v0.15.0-rc.0 branch from 7526104 to c7e301d Compare February 6, 2023 15:51
@kimwnasptd
Copy link
Member

I manually run the test in my laptop and the Experiment completed as expected. I'll manually merge the PR and look into the test in parallel

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DomFleischmann, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kimwnasptd kimwnasptd merged commit f7b75c6 into kubeflow:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants