Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Knative serving to 1.10.2 and eventing to 1.10.1 #2486

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

annajung
Copy link
Member

Which issue is resolved by this Pull Request:
Part of #2450

Description of your changes:

  • Upgrade Knative serving to 1.10.2
  • Upgrade Knative eventing to 1.101

cc @kimwnasptd

@annajung
Copy link
Member Author

Hi @yuzisun, Knative 1.10.x was decided in #2450. However, wanted to check in with you to see if this is appropriate for the next Kubeflow 1.8 release and if this would be compatible with KServe.

Anna Jung (VMware) added 2 commits July 25, 2023 14:08
Signed-off-by: Anna Jung (VMware) <[email protected]>
@annajung annajung force-pushed the upgrade-knative-1-10 branch 2 times, most recently from f52e907 to 4b85b83 Compare July 25, 2023 22:02
@annajung
Copy link
Member Author

I used upterm to see what's happening inside the cluster, and it looks like a few of the pods are not coming up because of insufficient resources, so they're in a pending state until the timeout hits, which results in a failed test.

I will take a deeper look into it this week

@annajung
Copy link
Member Author

Due to insufficient resources and the default setting that does not allow scheduling pods on the control plane nodes, at some point in the test, pods cannot run and stay in the pending state and fails to meet the condition check for all pods in "ready" state.

It looks like there are two approaches to solving the issue, both have been tested and were successful in running the KServe test

  1. Allow scheduling on the control plane
  2. Add another worker for kind installation

Not sure which one is better approach @kimwnasptd thoughts?

@kimwnasptd
Copy link
Member

@annajung I'd also vote for adding another worker node in our config file, just to unblock us for now.

Signed-off-by: Anna Jung (VMware) <[email protected]>
@annajung
Copy link
Member Author

@yuzisun Looks like KServe is using serving 1.10.1 and eventing 1.10.0 according to the quick install script and the github actions, do you have any concerns with 1.10.2 and eventing 1.10.1?

we like to get this in before the feature freeze Aug 2nd

@kimwnasptd
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annajung, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants