Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync kubeflow pipelines manifests 2.1.0 #2695

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Sync kubeflow pipelines manifests 2.1.0 #2695

merged 3 commits into from
Apr 30, 2024

Conversation

juliusvonkohout
Copy link
Member

@juliusvonkohout juliusvonkohout self-assigned this Apr 30, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@juliusvonkohout juliusvonkohout force-pushed the sync-kubeflow-pipelines-manifests-2.1.0 branch from c5a0d45 to 25ae2ac Compare April 30, 2024 07:35
@juliusvonkohout
Copy link
Member Author

I think Deploy and test Kubeflow Pipelines manifests with m2m auth in KinD / build (pull_request) supersedes
Build & Apply Kubeflow Pipelines manifests in KinD / build (pull_request). Or should we fix it?

@rimolive
Copy link
Member

We must wait for Kubeflow Pipelines 2.2.0 to be released. This is the version it will be available for Kubeflow 1.9

@juliusvonkohout
Copy link
Member Author

juliusvonkohout commented Apr 30, 2024 •
edited
Loading

We must wait for Kubeflow Pipelines 2.2.0 to be released. This is the version it will be available for Kubeflow 1.9

I still would like to get this release from March 25 (so only last month) in and update the synchronization script and tests in this PR.

If Google adds a new release i can do the update as well. This way we also get earlier testing exposure in RC0

So please /LGTM if there is nothing problematic

@rimolive
Copy link
Member

Ok, fair enough.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 30, 2024
@google-oss-prow google-oss-prow bot merged commit 6e86079 into master Apr 30, 2024
7 checks passed
@juliusvonkohout juliusvonkohout mentioned this pull request May 7, 2024
Closed
@juliusvonkohout juliusvonkohout deleted the sync-kubeflow-pipelines-manifests-2.1.0 branch May 16, 2024 12:38
doncorsean pushed a commit to doncorsean/kubeflow-manifests that referenced this pull request Jul 18, 2024
@juliusvonkohout
Sync kubeflow pipelines manifests 2.1.0 (kubeflow#2695)
f231f2b 
* Update kubeflow/pipelines manifests from 2.1.0

Signed-off-by: juliusvonkohout <[email protected]>

* Update sync-pipelines-manifests.sh

Signed-off-by: juliusvonkohout <[email protected]>

* old test is superseeded by nb_controller_m2m_kind_test.yaml

Signed-off-by: juliusvonkohout <[email protected]>

---------

Signed-off-by: juliusvonkohout <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rimolive rimolive Awaiting requested review from rimolive

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@rimolive rimolive

@juliusvonkohout juliusvonkohout

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliusvonkohout @rimolive