Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize kubeflow training operator manifests from v1.8.0-rc.1 #2769

Merged

Conversation

juliusvonkohout
Copy link
Member

the script had some issues, but i hope it is fine now @rimolive

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tenzen-y
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/lgtm

@juliusvonkohout juliusvonkohout force-pushed the sync-kubeflow-training-operator-manifests-v1.8.0-rc.1 branch from 99354f5 to f50fdf4 Compare June 26, 2024 08:01
@google-oss-prow google-oss-prow bot removed the lgtm label Jun 26, 2024
@juliusvonkohout
Copy link
Member Author

/approve

sorry @tenzen-y @johnugeorge you have to /lgtm again since i had to sign the last commit. It should merge automatically afterwards.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jun 26, 2024
@google-oss-prow google-oss-prow bot merged commit 787cb98 into master Jun 26, 2024
8 checks passed
@juliusvonkohout juliusvonkohout deleted the sync-kubeflow-training-operator-manifests-v1.8.0-rc.1 branch June 26, 2024 08:55
juliusvonkohout added a commit that referenced this pull request Jun 26, 2024
)

* Update kubeflow/training-operator manifests from v1.8.0-rc.1

Signed-off-by: juliusvonkohout <[email protected]>

* Update sync-training-operator-manifests.sh

Signed-off-by: juliusvonkohout <[email protected]>

---------

Signed-off-by: juliusvonkohout <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants