-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ws): update Workspace
and WorkspaceKind
definitions
#16
feat(ws): update Workspace
and WorkspaceKind
definitions
#16
Conversation
Signed-off-by: Mathew Wicks <[email protected]>
I cant assign @jiridanek as a reviewer because he is not a member yet, but please take a look. |
look taken /lgtm |
@jiridanek: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…w#16) Signed-off-by: Mathew Wicks <[email protected]>
This PR continues from #6.
It makes the following changes to align with the updates discussed, see thesuperzapper/kubeflow-notebooks-v2-design@ee651ee for the changes.
The key changes are:
PodVolumes
becameWorkspacePodVolumes
.I have also re-ordered the types and added section headings to make the go files easier to read.