[KF 1.0 Compliance] app.kubernetes.io labels on every resource

[Bobgy]

Part of #2884
Compliance doc: https://github.com/kubeflow/community/blob/master/guidelines/application_requirements.md

Description	Category	Explanation
app.kubernetes.io labels on every resource	Required	Every resource that is part of the application should include the labels recommended by Kubernetes, currently:app.kubernetes.io/nameapp.kubernetes.io/instanceapp.kubernetes.io/versionapp.kubernetes.io/componentapp.kubernetes.io/part-ofapp.kubernetes.io/managed-bySee example here

[Bobgy]

The problem is that common labels feature in kustomize cannot be used for applying these labels: kubeflow/manifests#1131

Because it is applied to selectors too, while selectors have to be immutable for upgrade.

Due to the limitations, I think it's better to defer this requirement to post 1.0 until there's a maintainable solution.

Upstream kustomize has a solution to add labels commonly without changing selector: kubernetes-sigs/kustomize#1009 (comment)

but I tried, the feature wasn't even introduced in kustomize 3.1.0, it will take a long time before kubectl kustomize picks it up.

[Bobgy]

/cc @jlewi
Sounds reasonable to defer this until later than KFP 1.0?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[Bobgy]

/lifecycle frozen

[rimolive]

Closing this issue. Looks like the resources are already annotated.

/close

[google-oss-prow]

@rimolive: Closing this issue.

In response to this:

Closing this issue. Looks like the resources are already annotated.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.