Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline input description #448

Closed
gaoning777 opened this issue Dec 3, 2018 · 21 comments
Closed

Pipeline input description #448

gaoning777 opened this issue Dec 3, 2018 · 21 comments

Comments

@gaoning777
Copy link
Contributor

Displaying the descriptions of the input parameters by the pipeline authors such that pipeline users get a better understanding of them

@Ark-kun
Copy link
Contributor

Ark-kun commented Dec 4, 2018

This issue has two parts:

  1. The language to specify the descriptions in a pipeline defined using Python.
  2. The way to pass this information to the UI. For this part I propose passing the Component metadata and interface specs inside Argo template annotation. See Add component metadata to the generated Argo YAML for consumption by the UI #452

@gaoning777
Copy link
Contributor Author

@Ark-kun Is the input description already in the pipeline metadata section?

@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 3, 2019

This issue tracks the UX part of the feature.

@Ark-kun Ark-kun reopened this Sep 3, 2019
@Ark-kun
Copy link
Contributor

Ark-kun commented Sep 7, 2019

Is the input description already in the pipeline metadata section?

Yes.

@Ark-kun
Copy link
Contributor

Ark-kun commented Oct 19, 2019

We need to think of a way to specify the descriptions in a pipeline defined using Python.
Maybe docstring parsing can work.

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 11, 2019

The core issue is that we need to invent a way for pipeline authors to specify input descriptions.

Maybe we can use some docstring parser.

@Bobgy
Copy link
Contributor

Bobgy commented Nov 11, 2019

@Ark-kun It's not very clear to me how much is left preparing data to UI

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 12, 2019

@Ark-kun It's not very clear to me how much is left preparing data to UI

I guess we need to design the syntax first. The Frontend is already getting the descriptions (in annotation), but they're always missing/empty.

@Bobgy
Copy link
Contributor

Bobgy commented Nov 12, 2019

Thanks, so there's some dsl-compiler work left to define how description is included in annotation. Is my understanding correct? I will fill in the UI part after it's ready.

@gaoning777
Copy link
Contributor Author

/unassign @gaoning777

@Bobgy Bobgy added status/triaged Whether the issue has been explicitly triaged priority/p2 and removed priority/p1 labels Jan 22, 2020
@Bobgy Bobgy self-assigned this Jan 22, 2020
@Ark-kun
Copy link
Contributor

Ark-kun commented Jan 22, 2020

I think the issue and #2621 are kind of related.

That PR is more actionable, since the way to specify the pipeline parameter types already exists (and the information is available to FE).

I think we probably need more user signal.

I agree.

@stale
Copy link

stale bot commented Jun 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 24, 2020
@stale
Copy link

stale bot commented Jul 1, 2020

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this as completed Jul 1, 2020
@Ark-kun Ark-kun reopened this Sep 18, 2020
@stale stale bot removed the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Sep 18, 2020
@Bobgy
Copy link
Contributor

Bobgy commented Sep 29, 2020

/frozen
this seems very useful

@stale
Copy link

stale bot commented Dec 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Dec 28, 2020
@stale
Copy link

stale bot commented Jul 8, 2021

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this as completed Jul 8, 2021
@Bobgy
Copy link
Contributor

Bobgy commented Jul 8, 2021

/reopen
/lifecycle frozen

@google-oss-robot
Copy link

@Bobgy: Reopened this issue.

In response to this:

/reopen
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot google-oss-robot added lifecycle/frozen and removed lifecycle/stale The issue / pull request is stale, any activities remove this label. labels Jul 8, 2021
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
HumairAK pushed a commit to red-hat-data-services/data-science-pipelines that referenced this issue Mar 11, 2024
@rimolive
Copy link
Member

rimolive commented Apr 5, 2024

Closing this issue. No activity for more than a year.

/close

Copy link

@rimolive: Closing this issue.

In response to this:

Closing this issue. No activity for more than a year.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants